Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library: Remove WP_Font_Family class that is no longer used. #58184

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

matiasbenedetto
Copy link
Contributor

What?

Remove WP_Font_Family class and its tests.

Why?

Because it's no longer used after #57688

How?

Removing the source code file and its tests.

Testing Instructions

  • Run unit tests
  • Use the font library and check everything works as expected.

Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/load.php

Copy link

Flaky tests detected in 6134d72.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7640757532
📝 Reported issues:

Copy link
Contributor

@pbking pbking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Font Library continues to work as expected. Unit tests continue to pass.

This change looks good to me.

@matiasbenedetto matiasbenedetto merged commit e464792 into trunk Jan 24, 2024
59 checks passed
@matiasbenedetto matiasbenedetto deleted the remove/wp-font-family-class branch January 24, 2024 13:49
@github-actions github-actions bot added this to the Gutenberg 17.6 milestone Jan 24, 2024
@getdave getdave added the Needs PHP backport Needs PHP backport to Core label Jan 26, 2024
@getdave
Copy link
Contributor

getdave commented Jan 26, 2024

I noticed this PR was merged after I raised the PHP Sync Tracking Issue for WP 6.5 and has changed PHP files that may need backporting to WP Core.

I believe this will be backported as part of a single backport for the Fonts API. It's been added to the Tracking Issue.

@creativecoder creativecoder added the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Jan 29, 2024
@cbravobernal
Copy link
Contributor

This PR was already in release/17.6, it seems that there is no need to backport it. @creativecoder

@cbravobernal cbravobernal removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Jan 30, 2024
@creativecoder
Copy link
Contributor

Thanks @c4rl0sbr4v0 for checking! We had a number of smaller font library PRs to touch things up in the last week, I wasn't sure which ones made it into the rc or not.

@youknowriad youknowriad added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Needs PHP backport Needs PHP backport to Core labels Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core [Feature] Font Library [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants